Added test proxy support #3217
Open
Added test proxy support #3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryOsterman
requested review from
a team,
RickWinter,
heaths,
j7nw4r,
jalauzon-msft and
vincenttran-msft
as code owners
github-actions
bot
added
Azure.Core
There was a problem hiding this comment.
Pull Request Overview
This PR adds test proxy support to the codebase by updating the instrument method signature to accept an optional RecordingOptions parameter. The changes enable control over test proxy behavior, particularly for performance tests, while maintaining backward compatibility by allowing None for most test cases.
Key Changes:
- Updated
Recording::instrumentmethod to accept anOption<RecordingOptions>parameter - Added
RemoveRecordingheader type to control whether recordings are removed during playback - Modified pipeline construction to move
LoggingPolicyafter per-try policies for proper test proxy integration - Updated all existing call sites to pass
Nonefor recording options, maintaining current behavior
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/azure_core_test/src/recording.rs | Added RecordingOptions parameter to instrument method and implemented RemoveRecording header |
| sdk/core/azure_core_test/src/proxy/policy.rs | Extended RecordingOptions struct with remove_recording field and updated header conversion |
| sdk/core/typespec_client_core/src/http/pipeline.rs | Moved LoggingPolicy after per-try policies in pipeline construction |
| sdk/keyvault/azure_security_keyvault_secrets/perf/get_secret.rs | Updated to use new RecordingOptions with RemoveRecording(false) for performance tests |
| Multiple test files | Updated all instrument calls to pass None for recording options |
| sdk/keyvault/assets.json | Updated test assets tag reference |
| sdk/core/azure_core_test/src/perf/README.md | Added documentation about performance tests being recorded tests |
… duration switches
… to recording to make recording infra happy
heaths
approved these changes
Oct 17, 2025
heaths
reviewed
Oct 17, 2025
…ly enabled through instrument_perf function
heaths
approved these changes
Oct 17, 2025
j7nw4r
reviewed
Oct 18, 2025
…ure_core_test now pass
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3099