Sync eng/common directory with azure-sdk-tools for PR 12529 #3244
Conversation
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with changes from azure-sdk-tools PR 12529, focusing on improving error handling and logging in stress test deployment scripts. The changes add early exit conditions and conditional logging to prevent misleading output when no stress test packages are found.
Key Changes
- Added early exit when no stress test packages are found, with a warning message
- Added conditional logging to only display chart files when they exist
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 | Added validation and early exit with warning when no packages found |
| eng/common/scripts/stress-testing/find-all-stress-packages.ps1 | Added conditional check to only log chart files when they exist |
| if (!$pkgs -or !$pkgs.Length) { | ||
| Write-Warning "No stress test packages found in $searchDirectory" | ||
| exit 0 |
There was a problem hiding this comment.
The warning message references $searchDirectory, but this variable doesn't appear to be defined in the visible context. The correct variable name should be $Directory based on the function's parameter name (visible at line 172 where it's passed to Get-ChildItem).
Copilot uses AI. Check for mistakes.
2 participants
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12529 See eng/common workflow