feat: Update existing SDK environment variables #1476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables processing of already admitted and modified containers. This might occur since the reinvocationPolicy has been set to `IfNeeded` (see Azure#794). Failing to do so might result in a situation where the wrong credentials are projected into the container, if another admission plugin modifies the `serviceAccountName`.
|
@microsoft-github-policy-service agree company="lise GmbH" |
…ariables-on-reinvocation
|
I am skeptical that is makes sense to support admission plugins that mutate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables processing of already admitted and modified containers. This might occur since the
reinvocationPolicyhas been set toIfNeeded#749.Reason for Change:
Not updating existing environment variables might result in a situation where the wrong credentials are projected into the container, whenever another admission plugin modifies the
serviceAccountName.Requirements
Issue Fixed:
Fixes #1475
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project?
If so, did you notify the maintainers and provide attribution?
not relevant