Merged
Conversation
Contributor
|
Test this change out locally with the following install scripts (Action run 21964464234) VSCode
Azure CLI
|
jeskew
reviewed
Jan 28, 2026
src/Bicep.Core.IntegrationTests/Extensibility/NamespaceFunctionTests.cs
Outdated
Show resolved
Hide resolved
| // Ideally extension namespace function authors shouldn't need to set this flag in the types.json at all if they have externalInputs in the "evaluatesTo" property | ||
| // Consider using visitor pattern to determine this automatically | ||
| if (!functionSymbol.FunctionFlags.HasFlag(FunctionFlags.RequiresExternalInput)) | ||
| catch (Exception) |
Member
There was a problem hiding this comment.
Is there any way to make this more specific? What exceptions are expected here?
Contributor
Author
There was a problem hiding this comment.
Added handling and unit test for ExpressionException if there is a failure running the arm expression evaluator.
c378ace to
4f6e5df
Compare
4f6e5df to
249ba06
Compare
jeskew
approved these changes
Feb 12, 2026
jeskew
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LanguageExpression. This is because the extension namespace function may define the expression that it should be reduced to which may not necessarily be the same as the function syntax.Example Usage
Namespace function definition:
Bicepparam:
Compiled json:
Checklist
Microsoft Reviewers: Open in CodeFlow