fix: Creation of manifest should not be seen as "ManifestUpdated"#116
Open
aagusuab wants to merge 2 commits intoAzure:masterfrom
Open
fix: Creation of manifest should not be seen as "ManifestUpdated"#116aagusuab wants to merge 2 commits intoAzure:masterfrom
aagusuab wants to merge 2 commits intoAzure:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
Previously, Successful application of manifest would update the condition of the work "Applied" to succeed, with a reason of "AppliedManifestUpdated" instead of original notion of "AppliedManifestComplete".
This change will make sure the correct reason is shown when resource is created.
I have:
Read and followed Caravel's Code of conduct.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer