Retry policies are now per request instead of per HttpManager #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie-Microsoft
changed the title
bgavrilMS
reviewed
Apr 24, 2025
bgavrilMS
reviewed
Apr 24, 2025
bgavrilMS
reviewed
Apr 24, 2025
bgavrilMS
reviewed
Apr 24, 2025
bgavrilMS
reviewed
Apr 24, 2025
bgavrilMS
reviewed
Apr 24, 2025
Robbie-Microsoft
changed the title
bgavrilMS
reviewed
Apr 28, 2025
src/client/Microsoft.Identity.Client/AppConfig/ApplicationConfiguration.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/ManagedIdentityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/ManagedIdentityTests.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/ManagedIdentityTests.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Apr 29, 2025
bgavrilMS
reviewed
Apr 30, 2025
bgavrilMS
reviewed
Apr 30, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ImdsManagedIdentitySource.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Apr 30, 2025
Member
bgavrilMS
left a comment
bgavrilMS
left a comment
There was a problem hiding this comment.
LGTM! Great PR. Just one minor comment.
src/client/Microsoft.Identity.Client/AppConfig/BaseAbstractApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/BaseAbstractApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Instance/Validation/AdfsAuthorityValidator.cs
Outdated
Show resolved
Hide resolved
gladjohn
approved these changes
May 1, 2025
Contributor
gladjohn
left a comment
gladjohn
left a comment
There was a problem hiding this comment.
looks good @Robbie-Microsoft, do we have a test with internal retries disabled to verify that exactly one outbound call is made on 5xx.
Contributor
Author
This functionality already existed, so I modified the existing test to include the updated reference to |
neha-bhargava
approved these changes
May 1, 2025
Contributor
neha-bhargava
left a comment
neha-bhargava
left a comment
There was a problem hiding this comment.
Looks good. Thanks
Robbie-Microsoft
commented
May 1, 2025
neha-bhargava
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same retry policy was previously being used for all Managed Identity sources and requests.
The retry policy will now be based on the Managed Identity source, and therefore will be per-request.