Update README.md #5283
Open
Update README.md #5283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -19,7 +19,7 @@ The following table lists MSAL.NET versions currently supported and receiving se | |||
|
|
|||
| | Major Version | Last Release | Patch Release Date | Support Phase|End of Support | | |||
| | --------------|--------------|--------|------------|--------| | |||
| | 4.x | [](https://www.nuget.org/packages/Microsoft.Identity.Client/) |Monthly| Active | Not planned.<br/>✅Supported versions: from 4.64.1 to [](https://www.nuget.org/packages/Microsoft.Identity.Client/)<br/>⚠️Unsupported versions `< 4.64.1`.| | |||
| | 4.x | [](https://www.nuget.org/packages/Microsoft.Identity.Client/) |Monthly| Active | Not planned.<br/>✅Supported versions: from 4.61.2 to [](https://www.nuget.org/packages/Microsoft.Identity.Client/)<br/>⚠️Unsupported versions `< 4.61.2`.| | |||
There was a problem hiding this comment.
[nitpick] This line repeats the same NuGet badge markdown multiple times. Consider extracting the badge into a variable or snippet to reduce duplication and simplify future updates.
Suggested change
| | 4.x | [](https://www.nuget.org/packages/Microsoft.Identity.Client/) |Monthly| Active | Not planned.<br/>✅Supported versions: from 4.61.2 to [](https://www.nuget.org/packages/Microsoft.Identity.Client/)<br/>⚠️Unsupported versions `< 4.61.2`.| | |
| | 4.x | [![NuGet][NuGet Badge]][NuGet] |Monthly| Active | Not planned.<br/>✅Supported versions: from 4.61.2 to [![NuGet][NuGet Badge]][NuGet]<br/>⚠️Unsupported versions `< 4.61.2`.| |
Copilot uses AI. Check for mistakes.
jennyf19
approved these changes
May 16, 2025
gladjohn
approved these changes
May 16, 2025
neha-bhargava
approved these changes
May 16, 2025
bgavrilMS
force-pushed
the
bgavrilMS-patch-2
branch
from
b0361cb to
af7ceb8
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the supported version range for MSAL.NET 4.x in the README.
- Changed the lower bound of supported versions from 4.64.1 to 4.61.2
- Updated the unsupported-version threshold formatting
Comments suppressed due to low confidence (2)
README.md:22
- The lower bound of the supported version was changed from 4.64.1 to 4.61.2. Please verify this is intentional or restore the original version if it was introduced by mistake.
| 4.x | [](https://www.nuget.org/packages/Microsoft.Identity.Client/) |Monthly| Active | Not planned.<br/>✅Supported versions: from 4.61.2 to [](https://www.nuget.org/packages/Microsoft.Identity.Client/)<br/>⚠️Unsupported versions `< 4.61.2`.|
README.md:22
- The less-than symbol is HTML-encoded as
<inside backticks. You can use the literal<inside backticks for clearer markdown rendering.
⚠️Unsupported versions `< 4.61.2`.
Frulfump
reviewed
May 19, 2025
| @@ -19,7 +19,7 @@ The following table lists MSAL.NET versions currently supported and receiving se | |||
|
|
|||
| | Major Version | Last Release | Patch Release Date | Support Phase|End of Support | | |||
| | --------------|--------------|--------|------------|--------| | |||
| | 4.x | [](https://www.nuget.org/packages/Microsoft.Identity.Client/) |Monthly| Active | Not planned.<br/>✅Supported versions: from 4.64.1 to [](https://www.nuget.org/packages/Microsoft.Identity.Client/)<br/>⚠️Unsupported versions `< 4.64.1`.| | |||
| | 4.x | [](https://www.nuget.org/packages/Microsoft.Identity.Client/) |Monthly| Active | Not planned.<br/>✅Supported versions: from 4.61.2 to [](https://www.nuget.org/packages/Microsoft.Identity.Client/)<br/>⚠️Unsupported versions `< 4.61.2`.| | |||
There was a problem hiding this comment.
As Copilot mentioned this is rendered as <
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
Testing
Performance impact
Documentation