Add issuer validation when making call to OIDC endpoint #5358
+136
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jun 24, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/CiamIntegrationTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jun 24, 2025
src/client/Microsoft.Identity.Client/Instance/Oidc/OidcRetrieverWithCache.cs
Outdated
Show resolved
Hide resolved
trwalke
reviewed
Jul 1, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/CiamIntegrationTests.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Instance/Oidc/OidcRetrieverWithCache.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Instance/Oidc/OidcRetrieverWithCache.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Instance/Oidc/OidcRetrieverWithCache.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 9, 2025
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Show resolved
Hide resolved
| httpManager.AddMockHandler(new MockHttpMessageHandler | ||
| { | ||
| ExpectedMethod = HttpMethod.Get, | ||
| ExpectedUrl = authority + "/" + Constants.WellKnownOpenIdConfigurationPath, |
There was a problem hiding this comment.
should you use template literal here?
$"{authority}/{Constants.WellKnownOpenIdConfigurationPath}"
There was a problem hiding this comment.
It now uses that literal, as well as the generic authority value found in TestConstants
bgavrilMS
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds issuer validation for OIDC scenarios: 3268765
As per OAuth spec, an issuer is valid if it matches the authority. In addition to the standard spec, there is also special validation for CIAM-style issuers which will mainly be relevant when using custom authorities in a CIAM scenario.