Open
Conversation
This PR adds app-level support for sending confidential client certificates over **mTLS transport** independently from token type.
Today, `WithMtlsProofOfPossession()` effectively drives both:
- the **token type** (`mTLS PoP`)
- the **certificate transport path** (mTLS)
That makes it hard to express the missing scenario:
- **mTLS transport + Bearer token**
This change introduces a new certificate option:
```csharp
new CertificateOptions
{
SendCertificateOverMtls = true
}
```
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a design mini-spec documenting a proposed API/config change to decouple token type (Bearer vs mTLS PoP) from certificate transport (request-body assertion vs mTLS handshake) for confidential client certificates, enabling the “mTLS transport + Bearer token” scenario.
Changes:
- Introduces a new proposed
CertificateOptions.SendCertificateOverMtlsflag (design-level) and defines its intended semantics. - Documents precedence rules between app-level defaults and request-level
.WithMtlsProofOfPossession(). - Adds a behavior matrix plus validation/implementation/testing notes for the new scenario.
You can also share your feedback on Copilot code review. Take the survey.
| public bool AssociateTokensWithCertificate { get; init; } = false; | ||
|
|
||
| // New | ||
| public bool SendCertificateOverMtls { get; init; } = false; |
Contributor
There was a problem hiding this comment.
This is going to be a breaking change right? How do you plan to handle that?
Contributor
There was a problem hiding this comment.
I think the table below answers that question. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds app-level support for sending confidential client certificates over mTLS transport independently from token type.
Today,
WithMtlsProofOfPossession()effectively drives both:mTLS PoP)That makes it hard to express the missing scenario:
This change introduces a new certificate option:
This keeps token type and certificate transport as separate concerns: