Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MSAL Browser events documentation to add guidance on appropriate usage of the event system (UI updates vs. application-critical logic/telemetry).
Changes:
- Adds a note warning against relying on events for critical application flows or telemetry.
shylasummers
previously approved these changes
Mar 18, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
The `[!NOTE]` block in `events.md` was missing the required `>` blockquote markers, causing it to render as plain text on GitHub instead of a formatted alert block. ## Changes - `lib/msal-browser/docs/events.md`: Add `>` blockquote prefix to `[!NOTE]` admonition to match GFM alert syntax used elsewhere in the repo (e.g., `caching.md`) **Before:** ```markdown [!NOTE] Please do not use events for critical flows... ``` **After:** ```markdown > [!NOTE] > Please do not use events for critical flows... ``` <!-- START COPILOT CODING AGENT TIPS --> --- 🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. [Learn more about Advanced Security.](https://gh.io/cca-advanced-security) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the MSAL Browser events documentation to add guidance on appropriate usage of the event system (UI updates vs. application-critical logic/telemetry).
Changes:
Adds a note warning against relying on events for critical application flows or telemetry.A