Skip to content

Fix sample matching and data retrieval in dashboard graph for percentage of reads #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

Aberdur
Copy link
Contributor

@Aberdur Aberdur commented Jun 5, 2025

PR Description

This PR resolves an issue in the percentage graph generation of the dashboard related to the processing of the diagnostic_pcr_Ct_value_1 values.

The previous implementation did not correctly filter and match samples when retrieving the number_of_reads_sequenced values from the database.

The corrected implementation now:

  • Retrieves all sample names from the database using collecting_lab_sample_id.
  • Filters out Ct values that do not correspond to samples in the database.
  • Retrieves the most recent number_of_reads_sequenced value per sample and ensures valid mapping.

Copy link
Member

@svarona svarona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aberdur Aberdur merged commit 148f13a into BU-ISCIII:develop Jun 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequencing Overview: Sequenced Base Pairs vs PCR Ct Values graph is empty
2 participants