Skip to content

Conversation

GeorgiaM66
Copy link
Contributor

Pull Request Review Checklist

Code Quality

  • Code follows project style guidelines (Google Java Style for backend, ESLint/Prettier for frontend)
  • Code is readable, maintainable, and uses clear naming
  • No unnecessary or commented-out code

Functionality

  • Code runs as intended and solves the issue/feature described
  • No breaking changes introduced without justification
  • Input validation and error handling are in place

Testing

  • Unit tests or integration tests cover new/changed logic
  • All existing tests pass
  • Manual testing steps (if any) are described in the PR

Security & Stability

  • No secrets, credentials, or sensitive data committed
  • SQL queries, API calls, or file operations are safe from injection or misuse
  • Dependencies added are necessary and from trusted sources

Project Process

  • Branch name and commit messages follow team conventions
  • PR is scoped to a single feature or fix (not overloaded)
  • Documentation, comments, or README updates provided if needed

GeorgiaM66 and others added 12 commits September 17, 2025 19:38
…d, added application-test.properties with dummy data, added authenticationEntryPoint so we get 401s instead of 403s, kept the key generator just in case, added checks to see what env we are in and autogenerate token if needed and persist locally.
[29] defined endpoints for /jobs/{id}, /jobs/save, /jobs/all.
[29] defined endpoints for /jobs/{id}, /jobs/save, /jobs/all.
@GeorgiaM66 GeorgiaM66 changed the title qichen-dev Implementation of #146 and endpoint definition of #29 Sep 19, 2025
Copy link
Contributor

@gopi-k-rayini gopi-k-rayini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Qi Chen, great work! I'm trying to compile your branch in my local to test these changes and I'm getting a few errors.

incompatible types: com.cs673.careerforge.domain.User cannot be converted to java.lang.Long

and some other compilation ones. Additionally I see that there's some conflicts with the dev branch. Please try to merge the current dev branch into yours and resolve the conflicts as needed and also resolve the Maven compilation issues.

Pedro Ramirez and others added 23 commits September 22, 2025 16:03
Integrated layout components and enhanced the design.
[29] defined endpoints for /jobs/{id}, /jobs/save, /jobs/all.
[29] defined endpoints for /jobs/{id}, /jobs/save, /jobs/all.
2. fixed test errors.
# Conflicts:
#	code/backend/pom.xml
#	code/backend/src/main/java/com/cs673/careerforge/exceptions/BizException.java
@gopi-k-rayini gopi-k-rayini merged commit 9ebc119 into dev Sep 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants