-
Notifications
You must be signed in to change notification settings - Fork 1
Implementation of #146 and endpoint definition of #29 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ting, and logging.
…ints with authentication middlewware.
…d, added application-test.properties with dummy data, added authenticationEntryPoint so we get 401s instead of 403s, kept the key generator just in case, added checks to see what env we are in and autogenerate token if needed and persist locally.
[29] defined endpoints for /jobs/{id}, /jobs/save, /jobs/all.
…ting, and logging.
[29] defined endpoints for /jobs/{id}, /jobs/save, /jobs/all.
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
Fix Credential Exposure
Fix POM File
…cation-test.properties here.
Implement User Authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Qi Chen, great work! I'm trying to compile your branch in my local to test these changes and I'm getting a few errors.
incompatible types: com.cs673.careerforge.domain.User cannot be converted to java.lang.Long
and some other compilation ones. Additionally I see that there's some conflicts with the dev branch. Please try to merge the current dev branch into yours and resolve the conflicts as needed and also resolve the Maven compilation issues.
Integrated layout components and enhanced the design.
reorganized folders
add placeholder
…ting, and logging.
[29] defined endpoints for /jobs/{id}, /jobs/save, /jobs/all.
…ting, and logging.
[29] defined endpoints for /jobs/{id}, /jobs/save, /jobs/all.
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
…or saveJob() (will be updated later).
2. fixed test errors.
# Conflicts: # code/backend/pom.xml # code/backend/src/main/java/com/cs673/careerforge/exceptions/BizException.java
Pull Request Review Checklist
Code Quality
No unnecessary or commented-out codeFunctionality
Testing
Security & Stability
Project Process