Skip to content

Conversation

gopi-k-rayini
Copy link
Contributor

@gopi-k-rayini gopi-k-rayini commented Sep 22, 2025

Pull Request Review Checklist

Code Quality

  • Code follows project style guidelines (Google Java Style for backend, ESLint/Prettier for frontend)
  • Code is readable, maintainable, and uses clear naming
  • No unnecessary or commented-out code

Functionality

  • Code runs as intended and solves the issue/feature described
  • No breaking changes introduced without justification
  • Input validation and error handling are in place

Testing

  • Unit tests or integration tests cover new/changed logic
  • All existing tests pass
  • Manual testing steps (if any) are described in the PR

Security & Stability

  • No secrets, credentials, or sensitive data committed
  • SQL queries, API calls, or file operations are safe from injection or misuse
  • Dependencies added are necessary and from trusted sources

Project Process

  • Branch name and commit messages follow team conventions
  • PR is scoped to a single feature or fix (not overloaded)
  • Documentation, comments, or README updates provided if needed

Copy link
Contributor

@SBurns002 SBurns002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - I just have a question about the UserType and how we're going to use it. I see we are using a getUserType in the Controller and the User.java file also has functionality to force the User Type to not be null - but where are we setting it? I don't think the user will be registering it, but I do see it as part of the JSON string for the /register endpoint. Are we just going to automatically set up everyone as an employee for now?

@gopi-k-rayini
Copy link
Contributor Author

Yes we should be setting everyone up as an employee. I know we decided on not scoping to employer, so that won't be used unless we plan on expanding the scope!

@gopi-k-rayini gopi-k-rayini merged commit eade7fc into dev Sep 23, 2025
4 checks passed
@gopi-k-rayini gopi-k-rayini deleted the addUserRegistration branch September 23, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants