From b9b04a15f7bf7ca0eec711bfbaed0e6603b5fc56 Mon Sep 17 00:00:00 2001 From: Stanford997 <545255309@qq.com> Date: Sun, 17 Nov 2024 22:59:40 -0500 Subject: [PATCH 1/2] [Fix]: Add user_state_collection handling in unit test upload_parse_resume --- be_repo/app.py | 1 - be_repo/tests/test_upload.py | 27 ++++++++++++++++++++++++--- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/be_repo/app.py b/be_repo/app.py index cdccf7cde..1622069ac 100644 --- a/be_repo/app.py +++ b/be_repo/app.py @@ -52,7 +52,6 @@ def upload_resume(): user_id = request.form.get('user_id') if not user_id: return jsonify({"error": "No user ID provided."}), 400 - # Vector the resume text return upload_parse_resume(request, resume_collection, user_state_collection) diff --git a/be_repo/tests/test_upload.py b/be_repo/tests/test_upload.py index b4494edfa..8a8a7e6b5 100644 --- a/be_repo/tests/test_upload.py +++ b/be_repo/tests/test_upload.py @@ -35,12 +35,19 @@ def test_upload_parse_resume_success(mock_parse_resume, app): mock_request.form = {'user_id': '123'} mock_resume_collection = MagicMock() + mock_user_state_collection = MagicMock() with app.app_context(): # Set up the application context - response = upload_parse_resume(mock_request, mock_resume_collection) + response = upload_parse_resume( + mock_request, + mock_resume_collection, + mock_user_state_collection + ) assert response[1] == 200 assert response[0].json['message'] == "File successfully uploaded and parsed" + mock_resume_collection.replace_one.assert_called_once() + mock_user_state_collection.replace_one.assert_called_once() @patch('modules.upload.parse_resume', return_value="Parsed resume text") @@ -53,12 +60,19 @@ def test_upload_parse_resume_invalid_format(mock_parse_resume, app): mock_request.form = {'user_id': '123'} mock_resume_collection = MagicMock() + mock_user_state_collection = MagicMock() with app.app_context(): - response = upload_parse_resume(mock_request, mock_resume_collection) + response = upload_parse_resume( + mock_request, + mock_resume_collection, + mock_user_state_collection + ) assert response[1] == 400 assert response[0].json['error'] == "Invalid file format, only PDF is allowed" + mock_resume_collection.replace_one.assert_not_called() + mock_user_state_collection.replace_one.assert_not_called() @patch('modules.upload.parse_resume', return_value="Parsed resume text") @@ -68,9 +82,16 @@ def test_upload_parse_resume_no_file(mock_parse_resume, app): mock_request.form = {'user_id': '123'} mock_resume_collection = MagicMock() + mock_user_state_collection = MagicMock() with app.app_context(): - response = upload_parse_resume(mock_request, mock_resume_collection) + response = upload_parse_resume( + mock_request, + mock_resume_collection, + mock_user_state_collection + ) assert response[1] == 400 assert response[0].json['error'] == "No file part in the request" + mock_resume_collection.replace_one.assert_not_called() + mock_user_state_collection.replace_one.assert_not_called() From 79a9ff0357368c259ee5773a1107d2603bc38c0e Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 18 Nov 2024 04:03:14 +0000 Subject: [PATCH 2/2] Update coverage on Readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index af90b5fa4..e9bb979f4 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ [![Conventional Commits](https://img.shields.io/badge/Conventional%20Commits-1.0.0-%23FE5196?logo=conventionalcommits&logoColor=white)](https://conventionalcommits.org) -Coverage
Coverage Report
FileStmtsMissCoverMissing
app.py1044656%40–41, 48–56, 61–91, 98, 102, 107, 111, 122, 127, 129, 134, 138, 147–161, 165
modules
   evaluator.py561475%96–97, 104–122
   langgraph_qa.py19185%2–33
   parser.py12192%20
   upload.py251924%16–54
TOTAL2169855% 
+Coverage
Coverage Report
FileStmtsMissCoverMissing
app.py1044656%40–41, 48–55, 60–90, 97, 101, 106, 110, 121, 126, 128, 133, 137, 146–160, 164
modules
   evaluator.py561475%96–97, 104–122
   langgraph_qa.py19185%2–33
   parser.py12192%20
   upload.py25388%23, 46–47
TOTAL2168262%