Undo some unnecessary logic for vertex pulling

Author: MiiBond

packages/dev/core/src/Engines/WebGPU/webgpuCacheRenderPipeline.ts

@@ -175,7 +175,7 @@ export abstract class WebGPUCacheRenderPipeline {
     public readonly mrtTextureArray: InternalTexture[];
     public readonly mrtTextureCount: number = 0;
 
-    public getRenderPipeline(fillMode: number, effect: Effect, sampleCount: number, textureState = 0, useVertexPulling: boolean = false): GPURenderPipeline {
+    public getRenderPipeline(fillMode: number, effect: Effect, sampleCount: number, textureState = 0): GPURenderPipeline {
         sampleCount = WebGPUTextureHelper.GetSample(sampleCount);
 
         if (this.disabled) {
@@ -196,7 +196,7 @@ export abstract class WebGPUCacheRenderPipeline {
         this._setRasterizationState(fillMode, sampleCount);
         this._setColorStates();
         this._setDepthStencilState();
-        this._setVertexState(effect, useVertexPulling);
+        this._setVertexState(effect);
         this._setTextureState(textureState);
 
         this.lastStateDirtyLowestIndex = this._stateDirtyLowestIndex;
@@ -777,13 +777,13 @@ export abstract class WebGPUCacheRenderPipeline {
         }
     }
 
-    private _setVertexState(effect: Effect, useVertexPulling: boolean = false): void {
+    private _setVertexState(effect: Effect): void {
         const currStateLen = this._statesLength;
         let newNumStates = StatePosition.VertexState;
 
         const webgpuPipelineContext = effect._pipelineContext as WebGPUPipelineContext;
-        const attributes = useVertexPulling ? [] : webgpuPipelineContext.shaderProcessingContext.attributeNamesFromEffect;
-        const locations = useVertexPulling ? [] : webgpuPipelineContext.shaderProcessingContext.attributeLocationsFromEffect;
+        const attributes = webgpuPipelineContext.shaderProcessingContext.attributeNamesFromEffect;
+        const locations = webgpuPipelineContext.shaderProcessingContext.attributeLocationsFromEffect;
 
         let currentGPUBuffer;
         let numVertexBuffers = 0;

packages/dev/core/src/Engines/abstractEngine.ts

@@ -225,9 +225,6 @@ export abstract class AbstractEngine {
     /** @internal */
     public _videoTextureSupported: boolean;
 
-    /** @internal */
-    public _useVertexPulling: boolean = false;
-
     protected _compatibilityMode = true;
     /** @internal */
     public _pointerLockRequested: boolean;

packages/dev/core/src/Engines/webgpuEngine.ts

@@ -319,8 +319,6 @@ export class WebGPUEngine extends ThinWebGPUEngine {
 
     private _commandBuffers: GPUCommandBuffer[] = [null as any, null as any];
 
-    private _dummyVertexBuffer: DataBuffer;
-
     // Frame Buffer Life Cycle (recreated for each render target pass)
 
     private _mainRenderPassWrapper: IWebGPURenderPassWrapper = {
@@ -3692,9 +3690,7 @@ export class WebGPUEngine extends ThinWebGPUEngine {
 
         this._currentMaterialContext.textureState = textureState;
 
-        // If vertex pulling, get a cached pipeline with empty vertex layout
-        // Pass a boolean here to getRenderPipeline that will cause the vertex layout to be empty
-        const pipeline = this._cacheRenderPipeline.getRenderPipeline(fillMode, this._currentEffect!, this.currentSampleCount, textureState, this._useVertexPulling);
+        const pipeline = this._cacheRenderPipeline.getRenderPipeline(fillMode, this._currentEffect!, this.currentSampleCount, textureState);
         const bindGroups = this._cacheBindGroups.getBindGroups(webgpuPipelineContext, this._currentDrawContext, this._currentMaterialContext);
 
         if (!this._snapshotRendering.record) {
@@ -3721,13 +3717,6 @@ export class WebGPUEngine extends ThinWebGPUEngine {
             );
         }
 
-        // If vertex pulling, bind a cached empty vertex buffer
-        if (this._useVertexPulling) {
-            if (!this._dummyVertexBuffer) {
-                this._dummyVertexBuffer = this.createVertexBuffer(new Float32Array(0), false, "DummyVertexPullingBuffer");
-            }
-            renderPass2.setVertexBuffer(0, this._dummyVertexBuffer.underlyingResource, 0, 0);
-        }
         const vertexBuffers = this._cacheRenderPipeline.vertexBuffers;
         for (let index = 0; index < vertexBuffers.length; index++) {
             const vertexBuffer = vertexBuffers[index];

packages/dev/core/src/Meshes/mesh.ts

@@ -2001,9 +2001,7 @@ export class Mesh extends AbstractMesh implements IGetSetVerticesData {
             engine.drawElementsType(fillMode, 0, subMesh._linesIndexCount, this.forcedInstanceCount || instancesCount);
         } else if (this._useVertexPulling) {
             // We're rendering the number of indices in the index buffer but the vertex shader is handling the data itself.
-            engine._useVertexPulling = true;
             engine.drawArraysType(fillMode, subMesh.indexStart, subMesh.indexCount, this.forcedInstanceCount || instancesCount);
-            engine._useVertexPulling = false;
         } else {
             engine.drawElementsType(fillMode, subMesh.indexStart, subMesh.indexCount, this.forcedInstanceCount || instancesCount);
         }