Added OpenPBR material and option to load using glTF #16773
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16773/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16773/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16773/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
I've been playing with mixins to try to remove a lot of duplicate code from the materials. I figured, if we can do this, it'll make my life easier when working on PBR2. I started with using mixins for some defines like UV1, UV2, etc. and the image-processing defines. Then, I tried actually making the imageProcessing logic into a mixin. This removes a whole bunch of duplicated stuff. |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
1 similar comment
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
| import type { ColorCurves } from "./colorCurves"; | ||
|
|
||
| // Explicit re-export of types to help TypeScript resolve them in declaration files | ||
| export type { Observer } from "../Misc/observable"; |
There was a problem hiding this comment.
I was getting errors in the npm run build:es6 involving ../.. import paths in this mixin.
An AI tool came up with the solution of adding these explicit exports. I don't really understand it but it works. It should be checked by someone who understands issues like this.
deltakosh
changed the title
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
I've noticed another issue with my changes that I don't understand. When running a Playground in Typescript mode, I get an error about not being able to find the BABYLON namespace. Any ideas what I might have done to cause that? |
MiiBond
force-pushed
the
mbond/pbr2-test-wip
branch
from
fe87eca to
3a5b609
Compare
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
1 similar comment
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Just so I understand correctly, for now, you have simply copied and pasted the existing PBR vertex/fragment shaders to create the OpenPBR shaders? I don't know if you have discussed the rewrite with @sebavan, but in my opinion, we should start from scratch without any defines and implement what is necessary for OpenPBR in the cleanest way possible. We can then configure the code with a few defines when necessary (but we should end up with far fewer definitions than we have now). |
This is actually what I started doing but I quickly realized that there is a ton of stuff that we still want to support like SH (in VS and FS), pre-filtered IBL, realtime IBL, analytic lights, etc. Also morph targets, skinning, etc. I'm still planning on removing ALL of the current material properties copied from PBRMaterial while retaining the logic for lighting, animation, etc. Ideally, we'll be able to separate lighting from material properties as much as possible in the shader... |
MiiBond
force-pushed
the
mbond/pbr2-test-wip
branch
from
df6a640 to
e908eee
Compare
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
No description provided.