Skip to content

[Fluent] DraggableLine, SpinButton/FLoatLineComponent, FileUploadLine with icon for NME #16876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2025

Conversation

georginahalpern
Copy link
Contributor

image
  • split up floatLineComponent into usage of spinbutton/numberinput, parsing props to send proper precision/step values
  • condense draggableLine and draggableLineWithButton (only the delete button being used)
  • upload fileUploadLine UX

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16876/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16876/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16876/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16876/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16876/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16876/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@georginahalpern georginahalpern added nme Node Material Editor tools and removed nme Node Material Editor labels Jul 12, 2025
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16876/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16876/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16876/merge/testResults/

@sebavan sebavan enabled auto-merge (squash) July 14, 2025 12:33
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16876/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16876/merge/?snapshot=refs/pull/16876/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16876/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16876/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 14, 2025

@sebavan sebavan merged commit b7cca8f into BabylonJS:master Jul 14, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants