-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Fluent] DraggableLine, SpinButton/FLoatLineComponent, FileUploadLine with icon for NME #16876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fluent] DraggableLine, SpinButton/FLoatLineComponent, FileUploadLine with icon for NME #16876
Conversation
georginahalpern
commented
Jul 11, 2025

- split up floatLineComponent into usage of spinbutton/numberinput, parsing props to send proper precision/step values
- condense draggableLine and draggableLineWithButton (only the delete button being used)
- upload fileUploadLine UX
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
packages/dev/sharedUiComponents/src/fluent/hoc/fileUploadLine.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/fluent/hoc/fileUploadLine.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/fluent/primitives/spinButton.tsx
Outdated
Show resolved
Hide resolved
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16876/merge/testResults/ |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16876/merge/testResults/ |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16876/merge/testResults/ |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16876/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16876/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16876/merge#BCU1XR#0 |
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16876/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16876/merge/ |
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16876/merge/testResults/ |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |