Skip to content

Inspector v2: Add Effect Layers to Scene Explorer #16877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025

Conversation

ryantrem
Copy link
Member

@ryantrem ryantrem commented Jul 11, 2025

Adds effect layers to scene explorer:

  • Add uniqueId to EffectLayer
  • Add observables for add/remove effect layers, and move the add/remove functions from effectLayerSceneComponent.ts to scene.ts. This seems to be a weird case unlike any other entity types where the actual array of EffectLayers lives in scene.ts, but the functions for adding/removing live in effectLayerSceneComponent.ts and the EffectLayer constructor directly pushes the instance into the scene.effectLayers array. To try to make things consistent, I've moved the addEffectLayer and removeEffectLayer to scene.ts, and call those functions from the EffectLayer constructor and dispose function. @sebavan
  • Add the effect layer explorer.
image

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16877/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16877/merge/?snapshot=refs/pull/16877/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16877/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16877/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 11, 2025

@ryantrem ryantrem marked this pull request as ready for review July 17, 2025 16:54
@ryantrem ryantrem merged commit 7f9b84e into BabylonJS:master Jul 17, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants