-
Notifications
You must be signed in to change notification settings - Fork 152
Typescript #1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Typescript #1554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lgtm
I think this is a step in the right direction for sure, but I feel like moving to esm packages instead of umd packages is a big part of what would be added value. But maybe I'm thinking too much about specifically having a test app for the Viewer. I suppose I could have a totally separate .ts entry point for that though, and have that one depend on esm packages. |
@ryantrem we can talk offline about that. Quickly, I've faced some blockers like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick first pass
@CedricGuillemet Please include me when we talk about this offline. |
Uh oh!
There was an error while loading. Please reload this page.