Skip to content

Remove deprecated SceneLoader calls from the docs #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Mar 24, 2025

Partly fixing #1312

Next PR will be for Mesh.CreateXXX

@bjsplat
Copy link

bjsplat commented Mar 24, 2025

snapshot for this PR available at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1314/merge

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick pass on the changes. There may be more issues.

@RaananW
Copy link
Member Author

RaananW commented Mar 24, 2025

Quick pass on the changes. There may be more issues.

thanks! going over all changes now.

@bjsplat
Copy link

bjsplat commented Mar 24, 2025

snapshot for this PR available at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1314/merge

@bjsplat
Copy link

bjsplat commented Mar 24, 2025

snapshot for this PR available at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1314/merge

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the PG updates

@RaananW
Copy link
Member Author

RaananW commented Mar 24, 2025

I didn't review the PG updates

The playgrounds are usually being tested with the screenshot-creation process. I made sure they all render correctly (and the same as before). Including meshNames, of course :-)

@bjsplat
Copy link

bjsplat commented Mar 24, 2025

snapshot for this PR available at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/DOCS/refs/pull/1314/merge

@sebavan sebavan merged commit 1ae75a9 into BabylonJS:master Mar 24, 2025
3 checks passed
@RaananW RaananW deleted the removeDeprecatedCalls branch March 24, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants