Skip to content

Proposal : First version of an ExternalUndoBufferInterface #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+115 −48
Open

Proposal : First version of an ExternalUndoBufferInterface #112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47d495a
First version of an ExternalUndoInterface
berdal84 Feb 13, 2020
fbcd8a8
fix(InsertText): an Undo record was not added when inserting a text
berdal84 Feb 15, 2020
e52da5a
fix(ExternalUndoBufferInterface): simplified declaration.
berdal84 Feb 15, 2020
b8899c8
fix(TextEditor): GetSelectionXXX now returns a new object instead of a
berdal84 Feb 15, 2020
50ad7d1
InsertText now takes a select argument to select the inserted text.
berdal84 Feb 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TextEditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ void TextEditor::AddUndo(UndoRecord& aValue)

// If a custom undo buffer is set we send the undo value on it
if ( mExternalUndoBuffer != nullptr) {
mExternalUndoBuffer->AddUndo(aValue, *this);
mExternalUndoBuffer->AddUndo(aValue);
}
}

Expand Down
6 changes: 1 addition & 5 deletions TextEditor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,11 +227,7 @@ class TextEditor
class ExternalUndoBufferInterface
{
public:
ExternalUndoBufferInterface() {};
~ExternalUndoBufferInterface() {};

virtual void AddUndo(UndoRecord&, TextEditor&)=0;

virtual void AddUndo(UndoRecord&) = 0;
};

typedef std::vector<UndoRecord> UndoBuffer;
Expand Down