Skip to content

Commit b60cb8e

Browse files
committed
Ignore HEAD and latest versions when checking whether version is wrong
1 parent 6945052 commit b60cb8e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

server/src/lib/diagnostics/ConfigDiagnostics.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ function checkRemoteFilterDefinition(filterDefinitionName: string, doc:RegolithC
8686
]);
8787
} else {
8888
const filter = JSON.parse(fs.readFileSync(doc.resolvePath(".regolith/cache/filters/" + filterDefinitionName + "/filter.json"), "utf8"));
89-
if (filter.version !== filterDefinition.version) {
89+
// TODO: Add checking for newer latest/HEAD version and caching it
90+
if (filter.version !== filterDefinition.version && filterDefinition.version !== "latest" && filterDefinition.version !== "HEAD") {
9091
diagnosticsBuilder.addDiagnosticForValue(["regolith", "filterDefinitions", filterDefinitionName, "version"], "Filter " + filterDefinitionName + " is outdated", DiagnosticSeverity.Warning,[
9192
{
9293
title: "Install all filters",

0 commit comments

Comments
 (0)