Fix/clink pyproject #272
Fix/clink pyproject #272
Conversation
Updated requires-python and tool configurations (black, ruff) to reflect Python 3.10 as the new minimum supported version. Also added clink* to package includes.
Summary of ChangesHello @starbased-co, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's Python environment and build configurations. It elevates the minimum required Python version to 3.10 and adjusts the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates pyproject.toml to drop support for Python 3.9, requiring Python 3.10+ instead, and adds the new clink package to the project's packaging configuration. The changes to the required Python version and the configurations for tools like black and ruff are consistent with this goal.
My review focuses on two key aspects of these changes. First, dropping support for a Python version is a breaking change that should be reflected in the project's versioning, likely requiring a major version bump. Second, I've identified a potential issue where the setuptools configuration being used requires a newer version of setuptools than what is specified in the build-system requirements. Addressing these points will improve the project's release management and build reliability.
| version = "7.1.0" | ||
| description = "AI-powered MCP server with multiple model providers" | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.10" |
There was a problem hiding this comment.
Changing the minimum required Python version from 3.9 to 3.10 is a breaking change for users on Python 3.9. According to semantic versioning principles, breaking changes should result in a major version bump (e.g., from 7.x.x to 8.0.0). Since this project uses semantic-release, please ensure the commit message for this change is formatted to indicate a breaking change, which will trigger the correct major version release.
| [tool.setuptools.packages.find] | ||
| include = ["tools*", "providers*", "systemprompts*", "utils*", "conf*"] | ||
| include = ["tools*", "providers*", "systemprompts*", "utils*", "conf*", "clink*"] |
There was a problem hiding this comment.
The [tool.setuptools.packages.find] configuration table is used here to discover packages. This feature was introduced in setuptools version 61.0.0. However, the build-system.requires on line 118 only specifies setuptools>=45. This could lead to inconsistent or failed builds in environments with an older setuptools version (between 45 and 61). It's recommended to update the requirement to setuptools>=61.0.0 in build-system.requires to ensure predictable behavior.
|
oi bugger off clanker |
|
Thank you! Should be fixed in the latest update, please confirm! |
confirm! |
2 participants
Feel free to decline this, just making this to add it to the issue