-
-
Notifications
You must be signed in to change notification settings - Fork 761
fix: correct PowerShell comment syntax and process-specific exit code handling in run-server.ps1 #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… Made Installing dependencies with uv safer on fail. Fixed syntax issue on line 1728.
Summary of ChangesHello @Darknoon5891, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness and correctness of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully addresses two critical issues in run-server.ps1
: an unclosed comment block that was disabling a large portion of the script, and incorrect exit code handling for the uv
process. The change to use process-specific exit codes instead of $LASTEXITCODE
is a significant improvement in reliability. The PR also includes numerous stylistic updates, such as moving catch
and else
blocks to new lines and aligning hashtables, which enhance code readability and consistency. However, I've identified a critical regression in the .env
file parsing logic that needs to be addressed.
if ($line -match '^([^#][^=]*?)=(.*)$') { | ||
$key = $matches[1].Trim() | ||
$value = $matches[2].Trim() -replace '^["'']|["'']$', '' | ||
$value = $matches[2].Trim() -replace '^["'']| ["'']$', '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regular expression used to remove quotes from environment variable values has been modified incorrectly. An extra space was added to the pattern, which will cause it to fail for correctly quoted values like "VALUE"
. This will lead to incorrect parsing of the .env
file and likely cause configuration-related failures. The space appears to be a typo and should be removed to restore the correct behavior.
$value = $matches[2].Trim() -replace '^["''']|["''']$', ''
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this looks like an issue
Thank you! |
Correct PowerShell comment syntax and process-specific exit code handling in run-server.ps1
Description
This PR fixes syntax errors in run-server.ps1 introduced in commit fe9968b when Qwen Code support was added. The issues prevented proper script execution and caused false failure reports.
Changes Made
Testing
Please review our Testing Guide before submitting.
Run all linting and tests (required):
Related Issues
Fixes #280
Checklist
source venv/bin/activate && ./code_quality_checks.sh