Implemented a mock http client for Issue #459#483
Open
jthomasprogrammer wants to merge 1 commit intoBenFradet:developfrom
Open
Implemented a mock http client for Issue #459#483jthomasprogrammer wants to merge 1 commit intoBenFradet:developfrom
jthomasprogrammer wants to merge 1 commit intoBenFradet:developfrom
Conversation
Put the httpclient reference behind a interface to add the ability for deterministic unit testing of api interactions in the future.
BenFradet
approved these changes
Oct 21, 2017
Owner
BenFradet
left a comment
BenFradet
left a comment
There was a problem hiding this comment.
LGTM 👍 , I'll let @JanOuborny have a look
Contributor
|
The problem here is, that there is already a pending implementation of loose coupling of the We need to merch both of these changes and I propose that we do that in a different branch. |
Author
|
Gotcha, didn't realized there was already a pending implementation. Should I do anything on my end to help with the merch of the changes? |
Owner
|
@averageprogrammer yup it'd be nice if you could have a look and review the other PR since you've done something similar 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put the httpclient reference behind a interface to add the ability for
deterministic unit testing of api interactions in the future.