fixes nightly tests and ghidra caching

also moves ghidra into a separate action as it turned out to be more
complex (with caching, so I stopped copy-pasting them).

Author: ivg

.github/actions/install-ghidra/action.yml

@@ -0,0 +1,25 @@
+name: "Installs Ghidra"
+description: "Installs ghidra libraries and data into the /usr prefix"
+inputs:
+  path:
+    description: "A path to the bap repository root"
+    default: ${{ github.workspace }}
+
+runs:
+  using: composite
+  steps:
+   - name: Cache Ghidra
+     id: cache-ghidra
+     uses: actions/cache@v4
+     with:
+       path: ghidra
+       key: ${{ runner.os }}-ghidra-${{ hashFiles(format('{0}/tools/install-ghidra.sh', inputs.path)) }}
+
+   - name: Build Ghidra
+     if: steps.cache-ghidra.outputs.cache-hit != 'true'
+     run: sudo sh ./${{inputs.path}}/tools/install-ghidra.sh ghidra
+     shell: bash
+
+   - name: Install Ghidra
+     run: sudo cp -r ghidra/* /usr/
+     shell: bash

.github/workflows/full.yml

@@ -1,5 +1,4 @@
 # tests all packages, including bap-extra
-# it requires ghidra, so it works only on ubuntu-latest
 name: full
 run-name: Testing everything in ${{ github.ref }}
 
@@ -17,22 +16,14 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v3
 
+      - name: Install Ghidra
+        uses: .github/actions/install-ghidra
+
       - name: Install Dejagnu
         run: |
           sudo apt-get update -y
           sudo apt-get install dejagnu -y
 
-      - name: Cache Ghidra
-        id: cache-ghidra
-        uses: actions/cache@v4
-        with:
-          path: /usr/share/ghidra
-          key: ${{ runner.os }}-ghidra
-
-      - name: Build and Install Ghidra
-        if: steps.cache-ghidras.outputs.cache-hit != 'true'
-        run: sudo sh ./tools/install-ghidra.sh
-
       - name: Install OCaml
         uses: ocaml/setup-ocaml@v3
         with:

.github/workflows/nightly.yml

@@ -23,22 +23,22 @@ jobs:
       OPAMRETRES: 8
 
     steps:
+      - name: Checkout the Tests
+        uses: actions/checkout@v4
+        with:
+          repository: BinaryAnalysisPlatform/bap
+          path: bap
+
+      - name: Install Ghidra
+        uses: ./bap/.github/actions/install-ghidra
+        with:
+          path: bap
+
       - name: Install Extra System Dependencies
         run: |
           sudo apt-get update -y
           sudo apt-get install dejagnu -y
 
-      - name: Cache Ghidra
-        id: cache-ghidra
-        uses: actions/cache@v4
-        with:
-          path: /usr/share/ghidra
-          key: ${{ runner.os }}-ghidra
-
-      - name: Build and Install Ghidra
-        if: steps.cache-ghidras.outputs.cache-hit != 'true'
-        run: sudo sh ./tools/install-ghidra.sh
-
       - name: Use OCaml ${{ matrix.ocaml-compiler }}
         uses: ocaml/setup-ocaml@v3
         with:
@@ -51,13 +51,7 @@ jobs:
             bap: git+https://github.com/BinaryAnalysisPlatform/opam-repository#testing
 
       - name: Build and Install BAP
-        run: opam install bap-extra bap-radare2
-
-      - name: Checkout the Tests
-        uses: actions/checkout@v4
-        with:
-          repository: BinaryAnalysisPlatform/bap
-          path: bap
+        run: opam install bap.master bap-extra.master bap-radare2.master
 
       - name: Run Functional Tests
         run: opam exec -- make -C bap check

.github/workflows/opam.yml

@@ -21,22 +21,14 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
+      - name: Install Ghidra
+        uses: .github/actions/install-ghidra
+
       - name: Install Dejagnu
         run: |
           sudo apt-get update -y
           sudo apt-get install dejagnu -y
 
-      - name: Cache Ghidra
-        id: cache-ghidra
-        uses: actions/cache@v4
-        with:
-          path: /usr/share/ghidra
-          key: ${{ runner.os }}-ghidra
-
-      - name: Build and Install Ghidra
-        if: steps.cache-ghidras.outputs.cache-hit != 'true'
-        run: sudo sh ./tools/install-ghidra.sh
-
       - name: Install OCaml ${{ matrix.ocaml-compiler }}
         uses: ocaml/setup-ocaml@v3
         with:

.github/workflows/release.yml

@@ -18,23 +18,15 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
+      - name: Install Ghidra
+        uses: .github/actions/install-ghidra
+
       - name: Install OCaml
         uses: ocaml/setup-ocaml@v3
         with:
           ocaml-compiler: ocaml-variants.4.14.2+flambda
           dune-cache: true
 
-      - name: Cache Ghidra
-        id: cache-ghidra
-        uses: actions/cache@v4
-        with:
-          path: /usr/share/ghidra
-          key: ${{ runner.os }}-ghidra
-
-      - name: Build and Install Ghidra
-        if: steps.cache-ghidras.outputs.cache-hit != 'true'
-        run: sudo sh ./tools/install-ghidra.sh
-
       - name: Add the testing Repository
         run: opam repo add bap git+https://github.com/BinaryAnalysisPlatform/opam-repository#testing
 

tools/install-ghidra.sh

@@ -20,7 +20,7 @@ set -x \
 && cd ${BUILDDIR} \
 && curl -sS -L -o ${GHIDRA_TARBALL} ${GHIDRA_SRC_URL} \
 && echo "${GHIDRA_SHA256} ${GHIDRA_TARBALL}" | sha256sum --check \
-&& tar xzvf ${GHIDRA_TARBALL} \
+&& tar xzf ${GHIDRA_TARBALL} \
 && rm ${LIBGHIDRA_PATH}/*bfd*.* ${LIBGHIDRA_PATH}/codedata.* \
 && make -j -C ${LIBGHIDRA_PATH} OPT_CXXFLAGS="${LIBGHIDRA_FLAGS}" libdecomp.a libsla.a \
 && make -j -C ${LIBGHIDRA_PATH} sleigh_opt \