Skip to content

Conversation

Ahriman
Copy link

@Ahriman Ahriman commented May 23, 2024

Hello,

I encountered an error while trying to update a message template and found the root cause.

The library currently uses the endpoint https://graph.facebook.com/API_VERSION/WABA_ID/message_templates/TEMPLATE_ID to update a template. However, according to the documentation, the correct endpoint should be https://graph.facebook.com/API_VERSION/TEMPLATE_ID.

Documentation reference:

WhatsApp Business Management API - Message Templates

I have made the necessary changes to correct this endpoint. Since this is a small change, I believe it should be straightforward to review.

Greetings.

@github-actions github-actions bot added java Pull requests that update Java code tests labels May 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and welcome! We are excited to see your first pull request and appreciate your contribution to our project. Our team is reviewing your changes and we will provide feedback as soon as possible. Thank you for taking the time to improve our project and we look forward to working with you!

@Ahriman
Copy link
Author

Ahriman commented May 24, 2024

It's my fisrt pull request on GitHub and I think that is needed to review because it can break using previous API versions

Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (8e20a52) to head (12920af).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #189   +/-   ##
=========================================
  Coverage     85.77%   85.77%           
  Complexity      512      512           
=========================================
  Files           164      164           
  Lines          1244     1244           
  Branches         12       12           
=========================================
  Hits           1067     1067           
  Misses          158      158           
  Partials         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skennic
Copy link

skennic commented Jun 13, 2025

Hello @Bindambc,

I stumbled upon the same problem and wondered why this PR is not yet merged as it seems to fix the changed API URI.
Can you take a look again?

Kind Regards
Ken-Nic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants