-
Notifications
You must be signed in to change notification settings - Fork 227
hash.tsv does not contain the hash (a.k.a. image_name) #2514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The hashes are computed by the multipackage helper service anyway, so they could probably be easily included in the PR submission. It would also be possible to make a test for the PRs to check for the correctness of a sha1 hash. Please let us know if contributions to this effect would be welcome or if there are serious objections to the inclusion of the hashes in the hash tsv file. |
I have included some help in https://github.com/BioContainers/multi-package-containers/blob/master/README.md#searching-for-containers to help people "searching" for containers. Let me know if this solves your use-case. |
I still think it would be practical to have the hashes in the hash.tsv file, but I personally don't need it any more. |
The https://github.com/BioContainers/multi-package-containers/blob/master/combinations/hash.tsv file only contains the tools and build info for the mulled containers, but not the hash itself. I think it would make sense to include the computed hashes as well so the containers can easily be found and used from the information provided in this file.
The text was updated successfully, but these errors were encountered: