Skip to content

Fix DiffusionGrid::GetConcentration error label#458

Open
stanbot8 wants to merge 1 commit intoBioDynaMo:masterfrom
stanbot8:fix/getconcentration-error-label
Open

Fix DiffusionGrid::GetConcentration error label#458
stanbot8 wants to merge 1 commit intoBioDynaMo:masterfrom
stanbot8:fix/getconcentration-error-label

Conversation

@stanbot8
Copy link
Copy Markdown
Contributor

@stanbot8 stanbot8 commented Mar 4, 2026

Summary

  • The out-of-bounds error in GetConcentration incorrectly identifies itself as ChangeConcentrationBy, making it impossible to distinguish read vs write OOB errors when debugging.

Test plan

  • Existing unit tests pass (no behavioral change, label only)

@sportokalidis
Copy link
Copy Markdown
Contributor

Hi @stanbot8,

Thanks for the contribution! I’ll review the changes and get back to you.

In the meantime: the CI issue that previously prevented macos-system-ci and ubuntu-system-ci from running has been fixed on main.

Could you please update your PR branch with the latest main (merge main into your branch, or rebase onto main) and push? That should trigger the missing system CI workflows on this PR.

@sportokalidis sportokalidis requested review from Copilot and sportokalidis and removed request for Copilot March 11, 2026 14:54
@stanbot8 stanbot8 force-pushed the fix/getconcentration-error-label branch from 8897528 to f7a6654 Compare March 11, 2026 16:34
@stanbot8 stanbot8 force-pushed the fix/getconcentration-error-label branch from f7a6654 to 61a331f Compare March 12, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants