String db update to latest versions #360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgarcia
requested changes
May 12, 2020
| "identifier": "stringdb", | ||
| "@type": "DataCatalog", | ||
| "@id": "https://string-db.org/", | ||
| "http://purl.org/dc/terms/conformsTo": "https://bioschemas.org/specifications/DataCatalog/0.3", |
There was a problem hiding this comment.
This link https://bioschemas.org/specifications/DataCatalog/0.3 does not work, the link should be https://bioschemas.org/profiles/DataCatalog/0.3-RELEASE-2019_07_01/
| { | ||
| "@type": "Dataset", | ||
| "@id": "https://string-db.org/#string.v11", | ||
| "http://purl.org/dc/terms/conformsTo": "https://bioschemas.org/specifications/Dataset/0.3", |
There was a problem hiding this comment.
| "license": { | ||
| "@type": "CreativeWork", | ||
| "name": "Creative Commons Attribution 4.0 International", | ||
| "url": "https://creativecommons.org/licenses/by/4.0/" |
There was a problem hiding this comment.
Should not we use this URL as the "@id" as well?
| "@type": "Dataset", | ||
| "@type": "bio:DataRecord", | ||
| "@id": "https://string-db.org/network/9606.ENSP00000379258", | ||
| "http://purl.org/dc/terms/conformsTo": "https://bioschemas.org/specifications/DataRecord/0.2-DRAFT", |
There was a problem hiding this comment.
| ], | ||
| "@type": "bio:Protein", | ||
| "@id": "https://string-db.org/network/9606.ENSP00000379258", | ||
| "http://purl.org/dc/terms/conformsTo": "https://bioschemas.org/specifications/Protein/0.9-DRAFT", |
There was a problem hiding this comment.
The currentProtein profile version is https://bioschemas.org/profiles/Protein/0.11-RELEASE/ should it not be better to update the example to the latest release rather than using an old DRAFT profile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request updates the string-db markup to comply with the latest profiles for Bioschemas.