[Do not review yet] tests: add GapLimits e2e test. #3641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
changed the title
bznein
force-pushed
the
gapLimitsE2Etest
branch
5 times, most recently
from
f35bc84 to
a56ab5a
Compare
bznein
force-pushed
the
gapLimitsE2Etest
branch
from
a56ab5a to
41ffd51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: something is wrong, this should not pass as
masterdoes not have the fix yet. However it does fail locally, looking into it.Tested by running the test on
masterand then by cherry-picking the commit at https://github.com/BitBoxSwiss/bitbox-wallet-app/pull/3640/commits. The first one fails, the other one succeedsBefore asking for reviews, here is a check list of the most common things you might need to consider: