Skip to content

Test transactions & address management #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rabbitholiness
Copy link
Contributor

@rabbitholiness rabbitholiness commented Jan 5, 2025

This PR adds a page for a dedicated user flow for automated test transactions for high-value transactions. The original idea is covered in this issue. The design is conceptually done and ready for review (Figma). What's missing so far are mobile screens.

It also adds a page with design concepts for how users might view and manage wallet addresses, including silent payment addresses. Detailed interactions and flows need to be fleshed out, but conceptual feedback would be nice. Especially managing silent payment sub-addresses (a.k.a. labels) will be more complex.

- created sub-folders to group related pages (e.g. design system).
- moved contacts and silent payment pages to milestone 1.8
-
@GBKS
Copy link
Contributor

GBKS commented Jan 7, 2025

Nice work. Can you please make the following tweaks?

  • Add a bit more of an explanation to the PR description. How far along are these designs? Anything missing or you'd like feedback on?
  • Add a Figma link to the design source
  • Link to the relevant design issue (props this one)
  • Not re-organize unrelated pages in this PR, that is best handled in a separate one

I'd also keep the test transactions feature out of the send milestones. It's more like a concept at this stage, like some of the other stuff at the bottom of the sidebar menu. We could put all those future ideas in a separate sub-category (but as I mentioned above, restructuring pages is not purpose of this PR).

@GBKS GBKS added the documentation Improvements or additions to documentation label Jan 7, 2025
@rabbitholiness
Copy link
Contributor Author

Thanks for taking a look. Worked on the suggested tweaks.

@rabbitholiness rabbitholiness changed the title Test transactions & contacts Test transactions & addresses Jan 8, 2025
@rabbitholiness rabbitholiness changed the title Test transactions & addresses Test transactions & address management Jan 8, 2025
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Let's get all your changes in and keep iterating.

@GBKS GBKS merged commit 7d0efc7 into BitcoinDesign:gh-pages Jan 13, 2025
@rabbitholiness rabbitholiness deleted the contacts-and-silent-payments branch January 15, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants