Skip to content

Commit 9cc7f23

Browse files
author
Jamie C. Driver
committed
consistency: namespace prefix unavoidable camera MIN/MAX macros
1 parent 90f8cff commit 9cc7f23

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

main/camera.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ void camera_set_debug_image(const uint8_t* data, const size_t len)
4545
#define CAMERA_IMAGE_RESOLUTION FRAMESIZE_QVGA
4646
#endif
4747

48-
#define MIN(a, b) (a < b ? a : b)
49-
#define MAX(a, b) (a > b ? a : b)
48+
#define CAM_MIN(a, b) (a < b ? a : b)
49+
#define CAM_MAX(a, b) (a > b ? a : b)
5050

5151
// The image from the camera framebuffer is scaled and cropped to fit the display image
5252
// (Based on Jade screen dimensions and the fact that the image is half the screen.)
@@ -69,20 +69,20 @@ void camera_set_debug_image(const uint8_t* data, const size_t len)
6969
// Scale down if image much larger than screen area in both dimensions
7070
// The numerator is fixed at 2, allowing half-integer scaling
7171
#define SCALE_NUMERATOR 2
72-
#define CALC_SCALE_DENOMINATOR(img, ui) MAX(SCALE_NUMERATOR, (((SCALE_NUMERATOR * img) + (ui / 2)) / ui))
72+
#define CALC_SCALE_DENOMINATOR(img, ui) CAM_MAX(SCALE_NUMERATOR, (((SCALE_NUMERATOR * img) + (ui / 2)) / ui))
7373
#define SCALE_DENOMINATOR \
74-
MIN(CALC_SCALE_DENOMINATOR(UI_CAMERA_IMAGE_WIDTH, UI_DISPLAY_WIDTH), \
74+
CAM_MIN(CALC_SCALE_DENOMINATOR(UI_CAMERA_IMAGE_WIDTH, UI_DISPLAY_WIDTH), \
7575
CALC_SCALE_DENOMINATOR(UI_CAMERA_IMAGE_HEIGHT, UI_DISPLAY_HEIGHT))
7676
#define CAM2UI(x) ((x * SCALE_NUMERATOR) / SCALE_DENOMINATOR)
7777
#define UI2CAM(x) ((x * SCALE_DENOMINATOR) / SCALE_NUMERATOR)
7878

7979
// Dimensions of image to display
80-
#define DISPLAY_IMAGE_WIDTH MIN(UI_DISPLAY_WIDTH, CAM2UI(UI_CAMERA_IMAGE_WIDTH))
81-
#define DISPLAY_IMAGE_HEIGHT MIN(UI_DISPLAY_HEIGHT, CAM2UI(UI_CAMERA_IMAGE_HEIGHT))
80+
#define DISPLAY_IMAGE_WIDTH CAM_MIN(UI_DISPLAY_WIDTH, CAM2UI(UI_CAMERA_IMAGE_WIDTH))
81+
#define DISPLAY_IMAGE_HEIGHT CAM_MIN(UI_DISPLAY_HEIGHT, CAM2UI(UI_CAMERA_IMAGE_HEIGHT))
8282

8383
// Crop central area of camera frame if scaled image still larger
84-
#define XOFFSET MAX(0, ((UI_CAMERA_IMAGE_WIDTH - UI2CAM(DISPLAY_IMAGE_WIDTH)) / 2))
85-
#define YOFFSET MAX(0, ((UI_CAMERA_IMAGE_HEIGHT - UI2CAM(DISPLAY_IMAGE_HEIGHT)) / 2))
84+
#define XOFFSET CAM_MAX(0, ((UI_CAMERA_IMAGE_WIDTH - UI2CAM(DISPLAY_IMAGE_WIDTH)) / 2))
85+
#define YOFFSET CAM_MAX(0, ((UI_CAMERA_IMAGE_HEIGHT - UI2CAM(DISPLAY_IMAGE_HEIGHT)) / 2))
8686

8787
static inline void copy_pixel(uint8_t dest[DISPLAY_IMAGE_HEIGHT][DISPLAY_IMAGE_WIDTH], const uint16_t destx,
8888
const uint16_t desty, const uint8_t src[CAMERA_IMAGE_HEIGHT][CAMERA_IMAGE_WIDTH], const uint16_t srcx,

0 commit comments

Comments
 (0)