-
Notifications
You must be signed in to change notification settings - Fork 83
Nginx webserver clarification #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "SQL script" is misleading as it's actually a php-script called
sql.php:DAlso isn't this just duplicated information from the entire section above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, fair point about it being a PHP script. I think it is useful to explain again here, since it shows people how that SQL.php translates into map tiles, and clarifies that it's only tiles, not live data.
I wonder if changing SQL to PHP in that sentence might clear things up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully my latest commit should resolve this ;)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is actually not necessarily true. It's possible to tell bluemap to write player-positions and markers (the "live" data) into the database at an interval, and then that script fetches that as well. Additionally the script also reads things like player-head-icons from the database, or marker icons if they are saved to the map's asset storage by an addon ^^
But i think what you meant by it (-> it fetches map-data, not static webapp-files) is coming across. So i am fine with merging it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, forgot you can write all that to the database.
What do you think of my change to line 69? I was 50/50 on it, since it's not a normal setup, but matches the example below. I believe that TechnicJelle feels similarly, from our conversation in the discord yesterday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk, both is fine i guess..
Most setups that end up in discord-support actually need
172.18.0.1in all 3 proxy-pass examples because they just have multiple pterodactyl-containers but different ports for each server ..But you can argue that there is no real point in having a network of servers if they are all on the same machine anyways, so whatever you choose, there is pro's and con's ^^