#355 Added menard equations 2.21 and 2.22 of CUR 228

[johan-tuls]

Description

Added Menard equations CUR 228

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

Checklist:

• I have added tests that prove my fix is effective or that my feature works
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• New and existing unit tests pass locally with my changes

[github-actions]

Thank you so much for contributing to Blueprints! This is your Pull Request # 2 to this project.
Your contributions help thousands of engineers work more efficiently and accurately.

Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added!

[rickdegoeij]

bit nitpicky sometimes, so feel free to interpret the comments :)

Comments that need address:

• Latex equations don't match implementation
• unittests for negative values
• add negative value checks in 2.22
• unittest for correctness of latex equations

[egarciamendez]

check comments from @rickdegoeij

I will let Enrique review as he is here today.

dismissed

[johan-tuls]

@GerjanDorgelo As the latex formula was also used in #522 please review the changes in that PR. All commented have been fixed.

[GerjanDorgelo]

@GerjanDorgelo As the latex formula was also used in #522 please review the changes in that PR. All commented have been fixed.

@johan-tuls i dont see any updates. Any chance you forgot to sync the changes?

[GerjanDorgelo]

i see this branch has been merged into #522. lets close this one then.