Adding the CancelFormerMomentumOnJump option on the script#12
Open
Eranot wants to merge 1 commit intoBrackeys:masterfrom
Open
Adding the CancelFormerMomentumOnJump option on the script#12Eranot wants to merge 1 commit intoBrackeys:masterfrom
Eranot wants to merge 1 commit intoBrackeys:masterfrom
Conversation
codelif
reviewed
Aug 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue #11
A boolean check was added to cancel former momentum on jump. Checking it will make the former momentum be canceled before the player jumps, resulting on the player always jumping the same amount, even if it is going down or up. In my experience, this makes the player feel a lot better.