Skip to content

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Sep 30, 2025

To merge when switching to challenge-tokenization branch

Waiting for Svg from Andrea (to change tokenization.svg)

Need to update challenges.id and userChallenges.challengeId in database

Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
speedrunethereum-v2 Ready Ready Preview Comment Oct 2, 2025 7:27am

@escottalexander
Copy link
Contributor

Thanks Rinat! Looks good to me.

Here is a small PR for adding the correct image: #330

@carletex Here is the SQL that I ran to add the challenge locally (for adding it to prod)🙏:

INSERT INTO challenges (
    id,
    challenge_name,
    description,
    sort_order,
    github,
    autograding,
    disabled,
    preview_image,
    icon,
    external_link
) VALUES (
    'tokenization',
    'Tokenization',
    '🎫 Create a unique token to learn the basics of 🏗️ Scaffold-ETH 2. You''ll use 👷‍♀️ HardHat to compile and deploy smart contracts. Then, you''ll use a template React app full of important Ethereum components and hooks. Finally, you''ll deploy an NFT to a public network to share with friends! 🚀',
    0,
    'scaffold-eth/se-2-challenges:challenge-tokenization',
    TRUE,
    FALSE,
    '/assets/challenges/tokenization.svg',
    NULL,
    NULL
);

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ Rinat! 🔥 Looking good to me, just a couple of comments:

  • Added a redirect for SEO and existing backlinks to keep working in d4375f1

  • This is the script to update user challenges after executing the insert from Elliot:

    UPDATE user_challenges set challenge_id='tokenization' where challenge_id like 'simple-nft-example';
    
  • We'll need to delete the old challenge from the database after user challenges are updated (can be done from the UI or with script), or it will show in the portfolio like this:
    image

    In case we want to do it with script:
    DELETE FROM challenges where challenge_id like 'simple-nft-example';

Also I think we need to coordinate with Ethereum.org team, or create a PR in their repo + ping them, so it doesn't show the old name and image in their website:

image

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
@carletex
Copy link
Member

carletex commented Oct 1, 2025

Hey all, thanks for this. Looking good!

Let's use this PR to coordinate the rest.

Stuff that we can do now:

Things to coordinate on release (in order, kind of):

*I thought this could be a nice use case for Drizzle custom migrations, but it won't work since the migration will run after the build (as per our build script in package.json), so it won't generate the right URLS, etc. We'll need to run it manually.

I'm just joining here the 3 statements that you guys posted (let's test it again):

/* Insert new challenge */
INSERT INTO challenges (
    id,
    challenge_name,
    description,
    sort_order,
    github,
    autograding,
    disabled,
    preview_image,
    icon,
    external_link
) VALUES (
    'tokenization',
    'Tokenization',
    '🎫 Create a unique token to learn the basics of 🏗️ Scaffold-ETH 2. You''ll use 👷‍♀️ HardHat to compile and deploy smart contracts. Then, you''ll use a template React app full of important Ethereum components and hooks. Finally, you''ll deploy an NFT to a public network to share with friends! 🚀',
    0,
    'scaffold-eth/se-2-challenges:challenge-tokenization',
    TRUE,
    FALSE,
    '/assets/challenges/tokenization.svg',
    NULL,
    NULL
);

/* Update relation on userChallenges table */
UPDATE user_challenges set challenge_id='tokenization' where challenge_id like 'simple-nft-example';

/* Remove simple-nft challenge */
DELETE FROM challenges where challenge_id like 'simple-nft-example';

Am I missing something? Thanks!!

@rin-st
Copy link
Member Author

rin-st commented Oct 1, 2025

Merge Autograder PR austintgriffith/speedrun-grader#28 + deploy to server

+ node install.js --challenge challenge-tokenization

Let's use this PR to coordinate the rest.

Thanks for writing all these points in one place!

Am I missing something?

Looks like everything is right

@carletex carletex marked this pull request as ready for review October 2, 2025 07:14
@carletex carletex merged commit 60c69a3 into main Oct 2, 2025
3 checks passed
@carletex carletex deleted the simple-nft-example-to-tokenization branch October 2, 2025 07:29
@carletex
Copy link
Member

carletex commented Oct 2, 2025

Merged, deployed everything, and tested it with Pablo. Everything seems to be working nicely.

@Pabl0cks
Copy link
Member

Pabl0cks commented Oct 2, 2025

Created the issue in the Ethereum.org repo, waiting for instructions for the PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants