-
Notifications
You must be signed in to change notification settings - Fork 17
simple-nft-example -> tokenization #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thanks Rinat! Looks good to me. Here is a small PR for adding the correct image: #330 @carletex Here is the SQL that I ran to add the challenge locally (for adding it to prod)🙏: INSERT INTO challenges (
id,
challenge_name,
description,
sort_order,
github,
autograding,
disabled,
preview_image,
icon,
external_link
) VALUES (
'tokenization',
'Tokenization',
'🎫 Create a unique token to learn the basics of 🏗️ Scaffold-ETH 2. You''ll use 👷♀️ HardHat to compile and deploy smart contracts. Then, you''ll use a template React app full of important Ethereum components and hooks. Finally, you''ll deploy an NFT to a public network to share with friends! 🚀',
0,
'scaffold-eth/se-2-challenges:challenge-tokenization',
TRUE,
FALSE,
'/assets/challenges/tokenization.svg',
NULL,
NULL
);
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ Rinat! 🔥 Looking good to me, just a couple of comments:
-
Added a redirect for SEO and existing backlinks to keep working in d4375f1
-
This is the script to update user challenges after executing the insert from Elliot:
UPDATE user_challenges set challenge_id='tokenization' where challenge_id like 'simple-nft-example';
-
We'll need to delete the old challenge from the database after user challenges are updated (can be done from the UI or with script), or it will show in the portfolio like this:
In case we want to do it with script:
DELETE FROM challenges where challenge_id like 'simple-nft-example';
Also I think we need to coordinate with Ethereum.org team, or create a PR in their repo + ping them, so it doesn't show the old name and image in their website:

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Hey all, thanks for this. Looking good! Let's use this PR to coordinate the rest. Stuff that we can do now:
Things to coordinate on release (in order, kind of):
*I thought this could be a nice use case for Drizzle custom migrations, but it won't work since the migration will run after the build (as per our I'm just joining here the 3 statements that you guys posted (let's test it again): /* Insert new challenge */
INSERT INTO challenges (
id,
challenge_name,
description,
sort_order,
github,
autograding,
disabled,
preview_image,
icon,
external_link
) VALUES (
'tokenization',
'Tokenization',
'🎫 Create a unique token to learn the basics of 🏗️ Scaffold-ETH 2. You''ll use 👷♀️ HardHat to compile and deploy smart contracts. Then, you''ll use a template React app full of important Ethereum components and hooks. Finally, you''ll deploy an NFT to a public network to share with friends! 🚀',
0,
'scaffold-eth/se-2-challenges:challenge-tokenization',
TRUE,
FALSE,
'/assets/challenges/tokenization.svg',
NULL,
NULL
);
/* Update relation on userChallenges table */
UPDATE user_challenges set challenge_id='tokenization' where challenge_id like 'simple-nft-example';
/* Remove simple-nft challenge */
DELETE FROM challenges where challenge_id like 'simple-nft-example'; Am I missing something? Thanks!! |
+
Thanks for writing all these points in one place!
Looks like everything is right |
Merged, deployed everything, and tested it with Pablo. Everything seems to be working nicely. |
Created the issue in the Ethereum.org repo, waiting for instructions for the PR 🙏 |
To merge when switching to
challenge-tokenization
branchWaiting for Svg from Andrea (to change
tokenization.svg
)Need to update challenges.id and userChallenges.challengeId in database