fix: issues for angular signals api #1750
Conversation
🦋 Changeset detectedLatest commit: 02bcfd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 02bcfd8.
☁️ Nx Cloud last updated this comment at |
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| import { Builder, builder } from '@builder.io/sdk'; | ||
| import { BuilderBlock as BuilderBlockComponent, BuilderBlocks, get, set } from '@fake'; | ||
|
|
||
|
|
||
|
|
||
|
|
||
| @Component({ | ||
| selector: 'form-component',standalone: true,imports: [CommonModule, BuilderBlockComponent, BuilderBlocks],template: \`<form | ||
| [attr.validate]=\\"validate()\\" | ||
| #formRef | ||
| [attr.action]=\\"!sendWithJs() && action()\\" | ||
| [attr.method]=\\"method()\\" | ||
| [attr.name]=\\"name()\\" | ||
| (submit)=\\"onSubmit($event)\\" | ||
| #_root | ||
| >@if(builderBlock() && builderBlock().children){ @for (block of | ||
| builderBlock()?.children;track trackByBlock0(index, block);let index = $index) | ||
| { | ||
| <builder-block-component | ||
| [block]=\\"block\\" | ||
| [index]=\\"index\\" | ||
| ></builder-block-component> | ||
| } } @if(submissionState() === 'error'){ | ||
| <builder-blocks | ||
| dataPath=\\"errorMessage\\" | ||
| [blocks]=\\"errorMessage()\\" | ||
| ></builder-blocks> | ||
| } @if(submissionState() === 'sending'){ | ||
| <builder-blocks | ||
| dataPath=\\"sendingMessage\\" | ||
| [blocks]=\\"sendingMessage()\\" | ||
| ></builder-blocks> | ||
| } @if(submissionState() === 'error' && responseData()){ | ||
| <pre class=\\"builder-form-error-text pre\\"> |
There was a problem hiding this comment.
@nmerget can we please add the htmlWhitespaceSensitivity in ToAngularOptions, this formatting will look a bit odd. It looks like the default is 'css' can we keep this instead of 'ignore' and only format the template? --html-whitespace-sensitivity (defaults to css)https://prettier.io/blog/2018/11/07/1.15.0.html#whitespace-sensitive-formatting
There was a problem hiding this comment.
I changed the default to css but used strict for the templates.
This will ensure that <span> or <a> stay inlined. I add a test to make sure it works.
The downside will be that the template may look a little bit wired sometimes, but I think it shouldn't be a big deal because the generated component will be minified anyways in production. And for debugging you could use your local prettier if it is required.
# Conflicts: # packages/core/src/__tests__/__snapshots__/angular.signals.test.ts.snap # packages/core/src/generators/angular/signals/component.ts # packages/core/src/generators/angular/signals/helpers/index.ts
Description
Please provide the following information:
Minor fixes for Angular
api=signalsMake sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier.yarn test:updateyarn g:changesetand follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.