[DEV-50470] Resolve full geo name display issue

- Migrate state.general.showFullGeoName to state.table.showFullGeoName
- Change the input to use the proper state.table.showFullGeoName property
- Update when to append full geo name based on the checkbox

Author: adamdoe

packages/core/components/DataTable/DataTable.tsx

@@ -34,7 +34,7 @@ export type DataTableProps = {
   defaultSortBy?: string
   displayGeoName?: (row: string) => string
   expandDataTable: boolean
-  formatLegendLocation?: (row: string) => string
+  formatLegendLocation?: (row: string, runtimeLookup: string) => string
   groupBy?: string
   headerColor?: string
   imageRef?: string
@@ -247,9 +247,14 @@ const DataTable = (props: DataTableProps) => {
       const csvData = config.table?.downloadVisibleDataOnly ? visibleData : rawData
 
       // only use fullGeoName on County maps and no other
-      if (config.general?.geoType === 'us-county') {
+      if (config.general?.geoType === 'us-county' || config.table.showFullGeoNameInCSV) {
         // Add column for full Geo name along with State
-        return csvData.map(row => ({ FullGeoName: formatLegendLocation(row[config.columns.geo.name]), ...row }))
+        return csvData.map(row => {
+          return {
+            FullGeoName: formatLegendLocation(row[config.columns.geo.name]),
+            ...row
+          }
+        })
       } else {
         return csvData
       }

packages/core/helpers/ver/4.25.4.ts

@@ -19,10 +19,21 @@ export const makeChartLegendsUnified = config => {
   }
 }
 
+const migrateTableGeneralSettings = config => {
+  if (config.type === 'map') {
+    if (config.general.showFullGeoNameInCSV) {
+      config.table.showFullGeoNameInCSV = config.general.showFullGeoNameInCSV
+    }
+    delete config.general.showFullGeoNameInCSV
+    return config
+  }
+}
+
 const update_4_25_4 = config => {
   const ver = '4.25.4'
   const newConfig = _.cloneDeep(config)
   makeChartLegendsUnified(newConfig)
+  migrateTableGeneralSettings(newConfig)
   newConfig.version = ver
   return newConfig
 }

packages/map/src/components/EditorPanel/components/EditorPanel.tsx

@@ -2854,7 +2854,7 @@ const EditorPanel = () => {
                 <label className='checkbox'>
                   <input
                     type='checkbox'
-                    checked={state.general.showFullGeoNameInCSV}
+                    checked={state.table.showFullGeoNameInCSV}
                     onChange={event => {
                       handleEditorChanges('toggleShowFullGeoNameInCSV', event.target.checked)
                     }}