Skip to content

Commit e154d43

Browse files
authored
Refactor: Viz Filters (#2056)
* refactored viz filter useEffect logic * merged useFilter refactor * moved Filter elements into individual components * removed unused variable * refactor getClassList
1 parent d5abeb1 commit e154d43

File tree

16 files changed

+588
-437
lines changed

16 files changed

+588
-437
lines changed

packages/core/components/EditorPanel/Inputs.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { memo, useEffect, useState } from 'react'
22
import { useDebounce } from 'use-debounce'
3-
import { DROPDOWN_STYLES } from '../Filters/Filters'
3+
import { DROPDOWN_STYLES } from '../Filters/components/Dropdown'
44

55
export type Input = {
66
label: string

packages/core/components/EditorPanel/VizFilterEditor/NestedDropdownEditor.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import _ from 'lodash'
22
import { SubGrouping, VizFilter, OrderBy } from '../../../types/VizFilter'
3-
import { filterOrderOptions, handleSorting } from '../../Filters'
3+
import { handleSorting } from '../../Filters/helpers/handleSorting'
4+
import { filterOrderOptions } from '../../../helpers/filterOrderOptions'
45
import FilterOrder from './components/FilterOrder'
56
import { Visualization } from '../../../types/Visualization'
67
import { useMemo } from 'react'

packages/core/components/EditorPanel/VizFilterEditor/VizFilterEditor.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ import { Visualization } from '../../../types/Visualization'
55
import { UpdateFieldFunc } from '../../../types/UpdateFieldFunc'
66
import _ from 'lodash'
77
import { MultiSelectFilter, VizFilter, VizFilterStyle } from '../../../types/VizFilter'
8-
import { filterStyleOptions, handleSorting, filterOrderOptions } from '../../Filters'
8+
import { handleSorting } from '../../Filters/helpers/handleSorting'
9+
import { filterOrderOptions } from '../../../helpers/filterOrderOptions'
10+
import { filterStyleOptions } from '../../Filters'
911
import FieldSetWrapper from '../FieldSetWrapper'
1012

1113
import FilterOrder from './components/FilterOrder'

0 commit comments

Comments
 (0)