FIX: [DEV-10387] - Fix Widget delete issue #2039
Conversation
| const rowIdx = widgetConfig.rowIdx | ||
|
|
||
| //delete the instantiated widgets | ||
| if (rows[rowIdx] && rows[rowIdx].columns && rows[rowIdx].columns.length && config.visualizations) { |
There was a problem hiding this comment.
can simplify this: rows[rowIdx]?.columns?.length
| @@ -71,7 +72,24 @@ const Widget = ({ | |||
|
|
|||
| const deleteWidget = () => { | |||
| if (!widgetConfig) return | |||
| // if last widget left in row remove whole row on delete | |||
| if (widgetConfig.colIdx === 0) { | |||
There was a problem hiding this comment.
what if it's the last column but it's at index 2?
There was a problem hiding this comment.
@joshlacey thats not issue. it will delete only last(one) widget.
|
|
||
| config.rows.splice(rowIdx, 1) // delete the row |
There was a problem hiding this comment.
I think the functionality should be that you delete the column but leave a placeholder there, a single column so that you can still add a widget there if you want.
say for example you put a chart widget when you meant to put a table widget, it would be annoying if the row disappeared when you deleted the mistaken chart widget. you'd have to add a new row and if you have a lot of rows, move it all the way to the top.
There was a problem hiding this comment.
@joshlacey i tryied to leave placeholder emty then the library that is being used thinks that widget is still there and cannot move new widget on top of it.and Cailin then asked to delete whole row
|
|
||
| config.rows.splice(rowIdx, 1) // delete the row | ||
| updateConfig({ ...config, rows, visualizations: newVisualizations }) |
There was a problem hiding this comment.
Can you match the pattern everywhere else here and call the dispatch function directly?
[Replace With Ticket Number]
Testing Steps
Open Dashboards.
When user deletes last widget in a row (clicking inner X button) it should delete whole row.
Before: it used to delete width but row was left.
See Image:
Self Review
Screenshots (if applicable)
Additional Notes