Skip to content

[DEV-50470] fix: showDownloadFullGeoName in csv files #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

adamdoe
Copy link
Collaborator

@adamdoe adamdoe commented Apr 10, 2025

Summary

At some point state.general.showFullGeoName was moved to state.table.showFullGeoName. This migrates configs to use that property and updates logic for when showFullGeoName should be added.

Testing Steps

  • Upload a county map config
  • Add a row that includes the fips column > Name the column the same name as the geo column
  • Data Table Settings > Select "Include full geo name in csv download"

Optional

Storybook Links

Screenshots

@adamdoe adamdoe added this to the 4.25.4 milestone Apr 10, 2025
@adamdoe adamdoe changed the base branch from main to dev April 10, 2025 21:25
- Migrate state.general.showFullGeoName to state.table.showFullGeoName
- Change the input to use the proper state.table.showFullGeoName property
- Update when to append full geo name based on the checkbox
@adamdoe adamdoe marked this pull request as ready for review April 10, 2025 21:32
@adamdoe adamdoe requested a review from joshlacey April 10, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant