Feature : [DEV-10497] - Add Line chart suppression for Dynamic Series #2075
Conversation
| dynamicCategory, | ||
| originalSeriesKey | ||
| } = props | ||
| const dynamicData = data.filter(d => { |
There was a problem hiding this comment.
Add checks for data before filtering.
Add checks for preliminaryData before running forEach
Add checks for dynamicCategory before attemptying to acces d[dynamicCategory]
| // Find applicable suppression data for the first item | ||
| const suppressionData = preliminaryData.find(isSuppressed) | ||
| const suppressionData = preliminaryData.find(item => isSuppressed(item, firstIndexDataItem)) | ||
| console.log(firstIndexDataItem, 'firstIndexDataItem') |
| // Find applicable suppression data for the first item | ||
| const suppressionData = preliminaryData.find(isSuppressed) | ||
| const suppressionData = preliminaryData.find(item => isSuppressed(item, firstIndexDataItem)) |
There was a problem hiding this comment.
Check for preliminaryData before running any functions on it.
| result.data[pairCount].push(modifiedItem) | ||
| result.style = suppressionData.style | ||
| result.color = colorScale(modifiedItem[dynamicCategory]) |
There was a problem hiding this comment.
Check for dynamicCategory before accessing it.
| siblingBefore = data[i] | ||
| break // Stop searching once a valid sibling is found | ||
| } | ||
| } | ||
|
|
||
| // Find the nearest numeric sibling after the current index | ||
| for (let j = index + 1; j < data.length; j++) { | ||
| if (isCalculable(data[j][seriesKey])) { | ||
| if (isCalculable(data[j][dynamicSeriesKey])) { |
There was a problem hiding this comment.
Throughout the rest of this PR, continue adding checks before accessing values that could potentially be undefined.
There was a problem hiding this comment.
it is checking here : const dynamicSeriesKey = dynamicCategory ? originalSeriesKey : seriesKey
There was a problem hiding this comment.
I added a test to the PR that will show the issue. Can you make sure that gets satisfied?
Summary
Testing Steps
Open Line chart
Configure Dynamic series
On Data series panel there a button "Add Special Line"
Add suppression line while series are dynamic
Note: For best results use Dynamic series mock data from story book as it is configured to render all lines while dynamic
Note: if data set has number values eg:100,500 etc you cannot suppress them, use values like "Abc, ZZZ etc.
Added a story as well, see attcahed image:
Optional
Storybook Links
Screenshots