Skip to content

Feature : [DEV-10119] - Allow Markup Includes & Filtered Text to Blank Out on Reset Value #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
+15 −0
Draft

Feature : [DEV-10119] - Allow Markup Includes & Filtered Text to Blank Out on Reset Value #2238

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98aa3e3
Allow Markup Includes & Filtered Text to Blank Out on Reset Value
Atash3000 Jul 21, 2025
ee282fd
Add guards
Atash3000 Jul 21, 2025
7213931
update logic
Atash3000 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/dashboard/src/helpers/getVizConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,21 @@ export const getVizConfig = (
}
return visConfigWithFootnotes
}
// for markup-include & filtered text reset data on Reset Value on Filters
const filters = config.dashboard.sharedFilters

const isResetActive = filters.some(f => f?.resetLabel && f?.resetLabel === f?.active)
const isMarkupUsed = filters.some(f => f?.usedBy?.includes(visualizationKey))
const isFilteredTextUsed = filters.some(f => f?.usedBy?.includes(visualizationKey))

if (visualizationKey.startsWith('markup-include') && isResetActive && isMarkupUsed) {
visualizationConfig.data = []
visualizationConfig.formattedData = []
}
if (visualizationKey.startsWith('filtered-text') && isResetActive && isFilteredTextUsed) {
visualizationConfig.data = []
visualizationConfig.formattedData = []
}

return visualizationConfig as AnyVisualization
}