Open
Conversation
seems to be some sort of bug in ProjectGridFunction on GPUs?
vladotomov
reviewed
Feb 7, 2026
| download and building of hypre, METIS and MFEM. | ||
|
|
||
| ### CMake | ||
|
|
Member
There was a problem hiding this comment.
This has become long, can we create INSTALL.md?
|
|
||
| #ifndef LAGHOS_ADAPTIVE_QUAD_HPP | ||
| #define LAGHOS_ADAPTIVE_QUAD_HPP | ||
|
|
Member
There was a problem hiding this comment.
Please move all Sedov-related files to /sedov
| { | ||
| if (Mpi::Root()) | ||
| { | ||
| // generated domain checks |
Member
There was a problem hiding this comment.
is this leftover debugging code? I don't think it's needed.
| for (int lev = 0; lev < rp_levels; lev++) { pmesh->UniformRefinement(); } | ||
|
|
||
| if (!cartesian_partitioning && enable_nc && dim > 1) | ||
| if (!cartesian_partitioning && enable_nc && dim > 1 && enable_rebalance) |
Member
There was a problem hiding this comment.
Please remove all rebalance logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a way to compare the Sedov density profile against the expected one by integrating |\rho_{sim} - \rho_{exact}|_2 over the domain.