err netconf REFACTOR missing attribute function

Author: lePici

src/err_netconf.c

@@ -122,6 +122,12 @@ np_err_missing_element(sr_session_ctx_t *ev_sess, const char *elem_name)
     sr_session_set_netconf_error(ev_sess, "protocol", "missing-element", NULL, NULL, msg, 1, "bad-element", elem_name);
 }
 
+void
+np_err_missing_attribute(sr_session_ctx_t *ev_sess, const char *message, const char *elem_name)
+{
+    sr_session_set_netconf_error(ev_sess, "protocol", "missing-attribute", NULL, NULL, message, 1, "bad-element", elem_name);
+}
+
 void
 np_err_bad_element(sr_session_ctx_t *ev_sess, const char *elem_name, const char *description)
 {

src/err_netconf.h

@@ -31,6 +31,8 @@ void np_err_lock_denied(sr_session_ctx_t *ev_sess, const char *err_msg, uint32_t
 
 void np_err_missing_element(sr_session_ctx_t *ev_sess, const char *elem_name);
 
+void np_err_missing_attribute(sr_session_ctx_t *ev_sess, const char *message, const char *elem_name);
+
 void np_err_bad_element(sr_session_ctx_t *ev_sess, const char *elem_name, const char *description);
 
 void np_err_invalid_value(sr_session_ctx_t *ev_sess, const char *description, const char *bad_elem_name);

src/netconf.c

@@ -155,7 +155,7 @@ np2srv_rpc_get_cb(sr_session_ctx_t *session, uint32_t UNUSED(sub_id), const char
         if (meta && !strcmp(lyd_get_meta_value(meta), "xpath")) {
             meta = lyd_find_meta(node->meta, NULL, "ietf-netconf:select");
             if (!meta) {
-                ERR("RPC with an XPath filter without the \"select\" attribute.");
+                np_err_missing_attribute(session, "Missing \"select\" attribute", "filter");
                 rc = SR_ERR_INVAL_ARG;
                 goto cleanup;
             }
@@ -933,7 +933,7 @@ np2srv_rpc_subscribe_cb(sr_session_ctx_t *session, uint32_t UNUSED(sub_id), cons
         if (meta && !strcmp(lyd_get_meta_value(meta), "xpath")) {
             meta = lyd_find_meta(node->meta, NULL, "ietf-netconf:select");
             if (!meta) {
-                ERR("RPC with an XPath filter without the \"select\" attribute.");
+                np_err_missing_attribute(session, "Missing \"select\" attribute", "filter");
                 rc = SR_ERR_INVAL_ARG;
                 goto cleanup;
             }