Update include/CLI/TypeTools.hpp

phlptp · agalanin-at-nvidia · web-flow · commit 2babd87b70e3 · 2025-05-26T07:13:35.000-07:00
Co-authored-by: Alexander Galanin &lt;agalanin@nvidia.com&gt;
diff --git a/include/CLI/TypeTools.hpp b/include/CLI/TypeTools.hpp
@@ -964,13 +964,13 @@ bool integral_conversion(const std::string &input, T &output) noexcept {
     // remove separators if present
     auto group_separators = get_group_separators();
     if(input.find_first_of(group_separators) != std::string::npos) {
+        std::string nstring = input;
         for(auto &separator : group_separators) {
             if(input.find_first_of(separator) != std::string::npos) {
-                std::string nstring = input;
                 nstring.erase(std::remove(nstring.begin(), nstring.end(), separator), nstring.end());
-                return integral_conversion(nstring, output);
             }
         }
+        return integral_conversion(nstring, output);
     }
 
     if(std::isspace(static_cast<unsigned char>(input.back()))) {

Original file line number	Diff line number	Diff line change
`@@ -964,13 +964,13 @@ bool integral_conversion(const std::string &input, T &output) noexcept {`
`964`	`964`	`// remove separators if present`
`965`	`965`	`auto group_separators = get_group_separators();`
`966`	`966`	`if(input.find_first_of(group_separators) != std::string::npos) {`
	`967`	`+ std::string nstring = input;`
`967`	`968`	`for(auto &separator : group_separators) {`
`968`	`969`	`if(input.find_first_of(separator) != std::string::npos) {`
`969`		`- std::string nstring = input;`
`970`	`970`	`nstring.erase(std::remove(nstring.begin(), nstring.end(), separator), nstring.end());`
`971`		`- return integral_conversion(nstring, output);`
`972`	`971`	`}`
`973`	`972`	`}`
	`973`	`+ return integral_conversion(nstring, output);`
`974`	`974`	`}`
`975`	`975`
`976`	`976`	`if(std::isspace(static_cast<unsigned char>(input.back()))) {`