-
Notifications
You must be signed in to change notification settings - Fork 384
move some of the Validators to an ExtraValidators file #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…le flag to disable compilation of some of them.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
===========================================
- Coverage 100.00% 99.90% -0.10%
===========================================
Files 17 19 +2
Lines 4546 5193 +647
Branches 0 1062 +1062
===========================================
+ Hits 4546 5188 +642
- Misses 0 5 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Will Fix #1191 |
@henryiii I think you are going to need to modify the codacy configuration on their website, I don't think I can fix the false positives on codacy in a configuration, so that will need to be handled by the administrator of the codacy configuration, which I think is you. I think we might want to just disable cppcheck on codacy, I am not seeing it providing much value over the other static checking we are doing. |
…ination with the validators
Rework some of the validator locations, add documentation, and fix some lingering issues with validators.
The extra will will enable additions of some new validators and reduce compile times for those that are not needed.