-
Notifications
You must be signed in to change notification settings - Fork 12
Shim class for loading G3SuperTimestream objects from disk #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A couple of missing features that I've noticed so far:
|
4cb3415
to
561ab9c
Compare
afa04ba
to
1251e2f
Compare
34b13ac
to
0335872
Compare
d18ec34
to
c7a7934
Compare
This PR is the first step in integrating the G3SuperTimestream class used by the Simons Observatory team into the core library. This class is a very thin wrapper around the core G3TimestreamMap class. It is designed only to load G3SuperTimestream objects from G3 files on disk for immediate conversion to G3TimestreamMap objects. It is also not exposed to the public or python API.
For integer data, add a '_nanmask' channel to flag missing samples, and gap-fill with zeros. For floating point data, just gap-fill with nans.
…user space Rearrange, no need for header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work! For the record, I tested this branch in combination with a draft PR of so3g that allows building against newer spt3g versions. With that combination, I was able to load some Simons Observatory data through this shim into the downstream sotodlib
and toast
data containers.
I think this is ready to merge, and we can iterate on any missing features in G3TimestreamMap separately. Any objections, @nwhitehorn or @mhasself ? |
This PR is the first step in integrating the G3SuperTimestream class used by the Simons Observatory team into the core library. This class is a very thin wrapper around the core G3TimestreamMap class. It is designed only to load G3SuperTimestream objects from G3 files on disk for immediate conversion to G3TimestreamMap objects. It is also not exposed to the public or python API.