Simplified examples for plotting cross-section and along slope velocity #420
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
thanks @ongqingyee!! I merged main and simplified a bit -- very minor things. This is ready to be reviewed... Anybody? |
navidcy
added
🛸 updating
| @@ -0,0 +1,967 @@ | |||
| { | |||
There was a problem hiding this comment.
Can delete "example" in title. I think we've been trying to make the titles the same as the notebook filenames.
Reply via ReviewNB
| @@ -0,0 +1,967 @@ | |||
| { | |||
There was a problem hiding this comment.
Anything we can do about these RuntimeWarnings? Maybe at the very least we could add a comment about why they are there and that they are ok to ignore?
Reply via ReviewNB
There was a problem hiding this comment.
# warnings are for dividing by NaN/0,
# i.e. when there is no topographic gradient and warning can be ignored
|
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:42Z "cross-slopE" |
|
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:43Z Line #6. pot_rho_2 Does the array need to be printed out here? |
|
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:44Z Line #3. pot_rho_2 Again, do we need to print the array here? |
|
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:44Z Line #3. pot_temp Also here? |
|
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:45Z Line #5. #pot_rho_2 = grid_depth.interp(grid_depth.interp(pot_rho_2, axis = 'X').chunk({'yt_ocean': 500}) , axis = 'Y', boundary = 'extend')#.sel(yu_ocean=lat_slice).sel(st_ocean=slice(0,depth))
Is this commented code needed? |
|
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:46Z Line #3. pot_rho_2_section.load() Could add a semicolon after this to suppress printing. |
|
Added some minor comments, but otherwise looks good to me @ongqingyee! |
…mples/Cross-slope_section.ipynb. Ready to be merged.
|
Changes have been made, thanks Adele! Changes now saved to my forked repo. How should I merge it into main? |
|
first @adele-morrison should approve then we should resolve the conflicts; could you do that or shall I? I am happy to deal with this when all dust settles (meaning, when all the edits-reviewing is done) |
by "saved" you mean the edits are pushed to your fork, right? |
Original
Examples/Cross-slope_section.ipynbnow separated into two scripts. Any advice on making it model agnostic would be great - having to manually drop geolat and geolon for only one model does not seem optimal.